[PATCH] Document new LLVM CMake interface and emit warning when using llvm_map_components_to_libraries

Brad King brad.king at kitware.com
Wed Jul 23 12:26:58 PDT 2014


On 07/23/2014 03:18 PM, Dan Liew wrote:
>> Use the type PATH rather than STRING so cmake-gui will use a
>> file-chooser dialog to edit the value interactively.  Or you
>> can just leave off the type: ``-DLLVM_DIR=/usr/share/llvm/cmake/``
>> and the find_package command should set the type for you.
> 
> Hmm I don't usually pass variables to cmake-gui.

Sorry, I meant if you construct a build tree on the command line
and then later edit it with cmake-gui.  Anyway, we can leave off
the type in the example.

> I've change the docs to use ``-DLLVM_DIR=``

Thanks.  I see: ``-DLLVM_DIR=/usr/share/llvm/cmake/``, but please drop
the trailing slash.  That was a typo in my previous message.  Sorry.

> I presume the attached patches are okay to commit once I've heard back
> from Takumi?

Yes, thanks.

-Brad




More information about the llvm-commits mailing list