[Polly][Refactor] IslAst [2/7]

David Peixotto dpeixott at codeaurora.org
Tue Jul 22 17:23:08 PDT 2014


+  Scop *S = nullptr;
+  IslAst *Ast = nullptr;

Non-static member initialization is not supported in MSVC 2012 according to
this table:
http://msdn.microsoft.com/en-us/library/hh567368.aspx#corelanguagetable. We
should just keep the constructor initialization here.

Otherwise, LGTM.


-- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted
by The Linux Foundation


> -----Original Message-----
> From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
> bounces at cs.uiuc.edu] On Behalf Of Johannes Doerfert
> Sent: Tuesday, July 22, 2014 9:01 AM
> Cc: llvm-commits at cs.uiuc.edu
> Subject: RE: [Polly][Refactor] IslAst [2/7]
> 
> Ping
> 
> --
> 
> Johannes Doerfert
> Employee of Qualcomm Innovation Center, Inc.
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted
> by The Linux Foundation
> 
> 
> -----Original Message-----
> From: llvm-commits-bounces at cs.uiuc.edu
> [mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Johannes Doerfert
> Sent: Thursday, July 17, 2014 9:07 AM
> To: 'Tobias Grosser'; simbuerg at fim.uni-passau.de
> Cc: llvm-commits at cs.uiuc.edu; 'Sebastian Pop'
> Subject: RE: [Polly][Refactor] IslAst [2/7]
> 
> Hey,
> 
>  Could somebody review this patch?
> 
> Best regards,
>   Johannes
> 
> --
> 
> Johannes Doerfert
> Employee of Qualcomm Innovation Center, Inc.
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted
> by The Linux Foundation
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list