[PATCH] Add LLVM_TOOLS_BINARY_DIR to LLVMConfig.cmake

Brad King brad.king at kitware.com
Tue Jul 22 10:49:40 PDT 2014


On 07/22/2014 01:39 PM, Dan Liew wrote:
> This adds the LLVM_TOOLS_BINARY_DIR variable to LLVMConfig.cmake and
> removes LLVM_BUILD_TOOLS_BINARY_DIR which is superfluous now.
> 
> Good to go?

The approach and patch look correct to me, though I haven't actually
applied and tested this one.

> when the autoconf/Makefile build system is used
> LLVMExports.cmake only contains LLVM library targets and not the
> executable targets.
> 
> I couldn't see any obvious way of fixing this (the Makefile system
> isn't globally aware of all the executable targets) so I left it.

For now the documentation can just say that the libraries are
available as imported targets but not the executables.  The
fact that the latter happen to be there when building LLVM
with CMake is a side-effect that applications should ignore.

Thanks,
-Brad




More information about the llvm-commits mailing list