[PATCH] Add LLVM_REQUIRES_EH and LLVM_REQUIRES_RTTI as options in CMake
Dan Liew
dan at su-root.co.uk
Tue Jul 22 08:59:34 PDT 2014
On 22 July 2014 13:38, Brad King <brad.king at kitware.com> wrote:
> On 07/21/2014 04:59 PM, Dan Liew wrote:
>> Okay fixed. Good to go now?
>
> Good. One minor tweak:
>
>> + message(WARNING "Exception handling requires RTTI. Enabling RTTI for ${name}")
>
> That warning is for project authors that set LLVM_REQUIRES_EH
> but not LLVM_REQUIRES_RTTI. Since they are internal variables
> there is nothing a user can do to fix this warning. Therefore
> you should use the AUTHOR_WARNING message type.
Okay committed in r213663 (with additional sphinx documentation and
AUTHOR_WARNING) and r213664. These need to go into the LLVM3.5 release
branch too. I'm not entirely sure how to do this correctly though from
git-svn so I'll leave this until someone answers [1].
[1] http://lists.cs.uiuc.edu/pipermail/llvmdev/2014-July/075012.html
Thanks,
Dan.
More information about the llvm-commits
mailing list