[PATCH] PR19958 wrong code at -O1 and above on x86_64-linux-gnu (InstCombine)

[Duncan P. N. Exon Smith]

LGTM.

> On 2014-Jul-17, at 13:33, suyog sarda <sardask01 at gmail.com> wrote:
> 
> + Duncan
> 
> 
> On Fri, Jul 18, 2014 at 1:56 AM, suyog <suyog.sarda at samsung.com> wrote:
> Hi Duncan, Nick
> 
> As there is no guidance in the coding standards,
> i looked at few files in InstCombine and comment style in them and
> i found it better to include braces, wherever there is a comment inside 'if'.
> 
> if ( ) {
> // comment
> }
> 
> I removed/didn't add braces where there is no comment and a single statement block.
> 
> Please see if this looks good to you !!
> 
> http://reviews.llvm.org/D4068
> 
> Files:
>   lib/Transforms/InstCombine/InstCombine.h
>   lib/Transforms/InstCombine/InstCombineCompares.cpp
>   test/Transforms/InstCombine/icmp-shr.ll
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 
> 
> 
> 
> -- 
> With regards,
> Suyog Sarda