[PATCH] extracting swapStruct into include/llvm/Support/MachO.h (no functional change)

[Artyom Skrobov]

Duncan, thank you for forwarding this on; Nick & Michael, thank you for the
review!
The patch committed as r213361-213362

Would you be able to also comment on the other small patch I proposed,
deleting the two unnecessary "using" statements, as quoted below?


-----Original Message-----
From: Artyom Skrobov [mailto:Artyom.Skrobov at arm.com] 
Sent: 09 July 2014 11:20
To: 'Duncan P. N. Exon Smith'
Cc: llvm-commits
Subject: RE: [PATCH] extracting swapStruct into include/llvm/Support/MachO.h
(no functional change)

 
>>>> Index: lib/Object/MachOObjectFile.cpp
>>>> ===================================================================
>>>> --- lib/Object/MachOObjectFile.cpp	(revision 210891)
>>>> +++ lib/Object/MachOObjectFile.cpp	(working copy)
>>>> @@ -24,9 +24,6 @@
>>>> #include <cstring>
>>>> #include <limits>
>>>> 
>>>> -using namespace llvm;
>>>> -using namespace object;
>>>> -
>>> 
>>> This cleanup seems unrelated.  You should leave this out.
>> 
>> Indeed this wasn't related to extracting SwapValue out of that file; but
is
>> this cleanup any controversial?

You didn't comment on this one: MachOObjectFile.cpp has both "using
namespace llvm::object;" and "namespace llvm { namespace object { } }" one
right after the other.

Surely it should only have one out of the two?