R600/SI: Add support for private arrays of all sizes

Tom Stellard tom at stellard.net
Thu Jul 17 19:42:04 PDT 2014


On Thu, Jul 17, 2014 at 03:36:17PM -0700, Matt Arsenault wrote:
> On 07/17/2014 12:46 PM, Tom Stellard wrote:
> >
> >     if (ST.is64bit()) {
> > -    // 32-bit private, local, and region pointers. 64-bit global and constant.
> > +    // 32-bit local, and region pointers. 64-bit private, global, and constant.
> >       Ret += "-p1:64:64-p2:64:64-p3:32:32-p4:64:64-p5:32:32-p24:64:64";
> >     }
> Is it really required to make private pointers be 64-bit? Can't we treat 
> them as a 32-bit offset to the 64-bit scratch buffer when it spills?
> 

That's actually what we are doing.  That comment is left over from my
first attempt to implement this when I tried to make private pointers
64-bit.  I can fix that comment.

-Tom

> 



More information about the llvm-commits mailing list