[PATCH 2/2] R600/SI: add sin-fold test case

Grigori Goronzy greg at chown.ath.cx
Thu Jul 17 15:41:48 PDT 2014


On 17.07.2014 23:59, Matt Arsenault wrote:
>> +++ b/test/CodeGen/R600/llvm.sin-fold.ll
>> @@ -0,0 +1,19 @@
>> +;RUN: llc < %s -march=r600 -enable-unsafe-fp-math -mcpu=SI | FileCheck %s -check-prefix=SI -check-prefix=FUNC
> 
> For future reference the < %s should go to the end before the | to make it easier to copy paste the run line when it fails.
> 
> This test should just go in the existing sin test file instead of creating a new one. With it moved, LGTM
> 

Okay, I guess I can just merge this with the other commit then?

The '< %s' seems to be at the "wrong" position in most tests though. Do
you think it makes sense to change all of it (in a separate commit)?

Grigori

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 246 bytes
Desc: OpenPGP digital signature
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140718/3b4d88aa/attachment.sig>


More information about the llvm-commits mailing list