[PATCH] Segregate FreeBSD-specific parts from sanitizer_procmaps_linux.cc
Alexey Samsonov
vonosmas at gmail.com
Thu Jul 17 13:41:34 PDT 2014
================
Comment at: lib/sanitizer_common/sanitizer_procmaps_common.cc:30
@@ +29,3 @@
+
+uptr ReadHex(const char *p) {
+ uptr v = 0;
----------------
Can you generalize this with ParseHex() function?
================
Comment at: lib/sanitizer_common/sanitizer_procmaps_linux.cc:21
@@ -27,3 +20,3 @@
// Linker initialized.
ProcSelfMapsBuff MemoryMappingLayout::cached_proc_self_maps_;
StaticSpinMutex MemoryMappingLayout::cache_lock_; // Linker initialized.
----------------
Shouldn't these vars be deleted from this file?
http://reviews.llvm.org/D4555
More information about the llvm-commits
mailing list