[PATCH] PR19958 wrong code at -O1 and above on x86_64-linux-gnu (InstCombine)
suyog
suyog.sarda at samsung.com
Thu Jul 17 13:26:37 PDT 2014
Hi Duncan, Nick
As there is no guidance in the coding standards,
i looked at few files in InstCombine and comment style in them and
i found it better to include braces, wherever there is a comment inside 'if'.
if ( ) {
// comment
}
I removed/didn't add braces where there is no comment and a single statement block.
Please see if this looks good to you !!
http://reviews.llvm.org/D4068
Files:
lib/Transforms/InstCombine/InstCombine.h
lib/Transforms/InstCombine/InstCombineCompares.cpp
test/Transforms/InstCombine/icmp-shr.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D4068.11609.patch
Type: text/x-patch
Size: 20673 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140717/f870257c/attachment.bin>
More information about the llvm-commits
mailing list