[PATCH] [compiler-rt] [asan] Refactor DescribeAddressIfStack to allow reuse for debugging API

Alexey Samsonov vonosmas at gmail.com
Wed Jul 16 14:18:56 PDT 2014


Please upload the patches with more context.

================
Comment at: lib/asan/asan_report.cc:351
@@ +350,3 @@
+  for (uptr i = 0; i < n_objects; i++) {
+    uptr beg, size;
+    uptr len;
----------------
While you're here, please initialize the variables in declaration
  uptr beg = (uptr)internal_simple_stroll(p, &p, 10);
  ...


================
Comment at: lib/asan/asan_report.cc:411
@@ +410,3 @@
+    Printf("AddressSanitizer can't parse the stack frame "
+           "descriptor: |%s|\n", frame_descr);
+  }
----------------
You should probably return from the function here.

http://reviews.llvm.org/D4545






More information about the llvm-commits mailing list