[LNT] r213124 - Add option to show small differences

[Yi Kong]

Author: kongyi
Date: Wed Jul 16 03:08:51 2014
New Revision: 213124

URL: http://llvm.org/viewvc/llvm-project?rev=213124&view=rev
Log:
Add option to show small differences

LNT ignores small changes by default to save users from getting
excessive amount of results. However this is counter-productive when
trying to examine benchmarks where <1% change is significant.

The patch adds option to show small differences.

Modified:
    lnt/trunk/lnt/server/reporting/analysis.py
    lnt/trunk/lnt/server/ui/templates/v4_run.html
    lnt/trunk/lnt/server/ui/views.py

Modified: lnt/trunk/lnt/server/reporting/analysis.py
URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/server/reporting/analysis.py?rev=213124&r1=213123&r2=213124&view=diff
==============================================================================
--- lnt/trunk/lnt/server/reporting/analysis.py (original)
+++ lnt/trunk/lnt/server/reporting/analysis.py Wed Jul 16 03:08:51 2014
@@ -72,7 +72,7 @@ class ComparisonResult:
         elif self.prev_failed:
             return UNCHANGED_PASS
 
-        # Ignore tests whose delt is too small relative to the precision we can
+        # Ignore tests whose delta is too small relative to the precision we can
         # sample at; otherwise quantization means that we can't measure the
         # standard deviation with enough accuracy.
         if abs(self.delta) <= 2 * value_precision * confidence_interval:
@@ -115,7 +115,7 @@ class ComparisonResult:
         # Otherwise, report any changes above 0.2%, which is a rough
         # approximation for the smallest change we expect "could" be measured
         # accurately.
-        if abs(self.pct_delta) >= .002:
+        if not ignore_small or abs(self.pct_delta) >= .002:
             if self.pct_delta < 0:
                 return IMPROVED
             else:

Modified: lnt/trunk/lnt/server/ui/templates/v4_run.html
URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/server/ui/templates/v4_run.html?rev=213124&r1=213123&r2=213124&view=diff
==============================================================================
--- lnt/trunk/lnt/server/ui/templates/v4_run.html (original)
+++ lnt/trunk/lnt/server/ui/templates/v4_run.html Wed Jul 16 03:08:51 2014
@@ -27,7 +27,7 @@
 
 {% macro get_cell_value(cr) %}
   {% set test_status = cr.get_test_status() %}
-  {% set value_status = cr.get_value_status() %}
+  {% set value_status = cr.get_value_status(ignore_small=not options.show_small_diff) %}
   {% set run_cell_value = "-" if cr.current is none else "%.4f" % cr.current %}
   
   {% if options.show_previous %}
@@ -215,6 +215,10 @@
       <td><input type="checkbox" name="show_sample_counts" value="yes" {{ "checked" if options.show_sample_counts else "" }}></td>
     </tr>
     <tr>
+      <td>Show Small Differences:</td>
+      <td><input type="checkbox" name="show_small_diff" value="yes" {{ "checked" if options.show_small_diff else "" }}></td>
+    </tr>
+    <tr>
       <td>Number of Comparison Runs:</td>
       <td><input type="text" name="num_comparison_runs" value="{{ options.num_comparison_runs }}"></td>
     </tr>

Modified: lnt/trunk/lnt/server/ui/views.py
URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/server/ui/views.py?rev=213124&r1=213123&r2=213124&view=diff
==============================================================================
--- lnt/trunk/lnt/server/ui/views.py (original)
+++ lnt/trunk/lnt/server/ui/views.py Wed Jul 16 03:08:51 2014
@@ -315,6 +315,7 @@ def v4_run(id):
     options['show_sample_counts'] = bool(request.args.get('show_sample_counts'))
     options['show_graphs'] = show_graphs = bool(request.args.get('show_graphs'))
     options['show_data_table'] = bool(request.args.get('show_data_table'))
+    options['show_small_diff'] = bool(request.args.get('show_small_diff'))
     options['hide_report_by_default'] = bool(
         request.args.get('hide_report_by_default'))
     options['num_comparison_runs'] = info.num_comparison_runs