[PATCH] Perform wildcard expansion in Process::GetArgumentVector on Windows (PR17098)

Hans Wennborg hans at chromium.org
Tue Jul 15 16:39:38 PDT 2014


================
Comment at: lib/Support/Windows/Process.inc:224-225
@@ +223,4 @@
+  WIN32_FIND_DATAW FileData;
+  HANDLE FindHandle = FindFirstFileExW(Arg, FindExInfoBasic, &FileData,
+                                       FindExSearchNameMatch, NULL, 0);
+  if (FindHandle == INVALID_HANDLE_VALUE) {
----------------
David Majnemer wrote:
> Can we use `FindFirstFile`?
Yes, it seems I'm not using any of the Ex capabilities.

================
Comment at: lib/Support/Windows/Process.inc:238
@@ +237,3 @@
+
+    SmallVector<char, MAX_PATH> Path = Dir;
+    llvm::sys::path::append(Path, StringRef(FileName.data(), FileName.size()));
----------------
As per your offline comment, I'll see if I can just reuse Dir and avoid this copying.

http://reviews.llvm.org/D4529






More information about the llvm-commits mailing list