[PATCH] Perform wildcard expansion in Process::GetArgumentVector on Windows (PR17098)

Hans Wennborg hans at chromium.org
Tue Jul 15 16:10:00 PDT 2014


Hi rnk, majnemer,

On Windows, wildcard expansion isn't performed by the shell, but left to the program itself. The common way to do this is to link with setargv.obj, which performs the expansion on argc/argv before main is entered. However, we don't use argv in Clang on Windows, but instead call GetCommandLineW so we can handle unicode arguments. This means we have to do wildcard expansion ourselves.

Here is a stab at making GetArgumentVector perform wildcard expansion. I'm very open for ideas on how to test this, and also if this is the right place for the code to live.

http://reviews.llvm.org/D4529

Files:
  lib/Support/Windows/Process.inc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D4529.11476.patch
Type: text/x-patch
Size: 3928 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140715/39d6812e/attachment.bin>


More information about the llvm-commits mailing list