[PATCH] [AArch64] Implement Clang CLI interface proposal about "-march".

Eric Christopher echristo at gmail.com
Tue Jul 15 14:48:37 PDT 2014

One inline comment.

Also, I'm seeing tests for -mtune and -mcpu, but very few for -march= behavior. Can you make some of those similar to the -mcpu ones to make sure both ways work?


Comment at: lib/Driver/Tools.cpp:1530
@@ +1529,3 @@
+                                  std::vector<const char *> &Features) {
+  SmallVector<StringRef, 8> Splited;
+  text.split(Splited, StringRef("+"), -1, false);
Same comment as last time. Split or Splitted. I'd prefer the first.


More information about the llvm-commits mailing list