[PATCH] MergeFunc: Don't merge functions with different range metadata on call/invoke
Nick Lewycky
nicholas at mxc.ca
Mon Jul 14 01:49:26 PDT 2014
Stepan Dyatkovskiy wrote:
> Hi Nick )
>
> OK, I'll commit it tomorrow.
>
> Can I do next commits to MergeFunctions in after-review mode (very
> carefully, checking everything and everywhere)?
Sure, you've essentially rewritten it at this point. If you're
comfortable that a patch to mergefunc doesn't need presubmit review,
then you can commit first and get review second.
Nick
>
> Thanks!
> -Stepan
>
> Nick Lewycky wrote:
>> Optional: I think the two tests could be merged into one file. Either
>> way, LGTM.
>>
>> http://reviews.llvm.org/D4246
>>
>>
>
>
More information about the llvm-commits
mailing list