[PATCH] PR19958 wrong code at -O1 and above on x86_64-linux-gnu (InstCombine)

[suyog]

Hi Duncan,

Made changes as per your suggestions :
- Wrote the whole logic in separate function. 
  Didn't make it 'static', took 'cue' from other 'Foldicmp' functions.
- Removed TODO, will probably raise a separate PR for it.
- Updated comments, removed extra braces.
- defined variables just before their use.

Can you please see if this looks good to you?
Your comments/suggestions are most welcomed.

Thanks,
Suyog

http://reviews.llvm.org/D4068

Files:
  lib/Transforms/InstCombine/InstCombine.h
  lib/Transforms/InstCombine/InstCombineCompares.cpp
  test/Transforms/InstCombine/icmp-shr.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D4068.11351.patch
Type: text/x-patch
Size: 20640 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140713/415b3432/attachment.bin>