[llvm] r212729 - Mips: Silence a -Wcovered-switch-default

Daniel Sanders Daniel.Sanders at imgtec.com
Thu Jul 10 09:26:19 PDT 2014


I just went to fix this but you've beaten me to it. Thanks.

> -----Original Message-----
> From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
> bounces at cs.uiuc.edu] On Behalf Of David Majnemer
> Sent: 10 July 2014 17:04
> To: llvm-commits at cs.uiuc.edu
> Subject: [llvm] r212729 - Mips: Silence a -Wcovered-switch-default
> 
> Author: majnemer
> Date: Thu Jul 10 11:04:04 2014
> New Revision: 212729
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=212729&view=rev
> Log:
> Mips: Silence a -Wcovered-switch-default
> 
> Remove a default label which covered no enumerators, replace it with a
> llvm_unreachable.
> 
> No functionality changed.
> 
> Modified:
>     llvm/trunk/lib/Target/Mips/MCTargetDesc/MipsABIFlagsSection.cpp
> 
> Modified:
> llvm/trunk/lib/Target/Mips/MCTargetDesc/MipsABIFlagsSection.cpp
> URL: http://llvm.org/viewvc/llvm-
> project/llvm/trunk/lib/Target/Mips/MCTargetDesc/MipsABIFlagsSection.cpp
> ?rev=212729&r1=212728&r2=212729&view=diff
> ==========================================================
> ====================
> --- llvm/trunk/lib/Target/Mips/MCTargetDesc/MipsABIFlagsSection.cpp
> (original)
> +++ llvm/trunk/lib/Target/Mips/MCTargetDesc/MipsABIFlagsSection.cpp
> Thu
> +++ Jul 10 11:04:04 2014
> @@ -23,9 +23,9 @@ uint8_t MipsABIFlagsSection::getFpABIVal
>      if (Is32BitABI)
>        return OddSPReg ? Val_GNU_MIPS_ABI_FP_64 :
> Val_GNU_MIPS_ABI_FP_64A;
>      return Val_GNU_MIPS_ABI_FP_DOUBLE;
> -  default:
> -    return 0;
>    }
> +
> +  llvm_unreachable("unexpected fp abi value");
>  }
> 
>  StringRef MipsABIFlagsSection::getFpABIString(FpABIKind Value) {
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list