[llvm] r212397 - Don't use StringRef iterator functions for data access
Alp Toker
alp at nuanti.com
Sun Jul 6 03:32:58 PDT 2014
Author: alp
Date: Sun Jul 6 05:32:55 2014
New Revision: 212397
URL: http://llvm.org/viewvc/llvm-project?rev=212397&view=rev
Log:
Don't use StringRef iterator functions for data access
And also remove some redundant casts from r212371.
Modified:
llvm/trunk/include/llvm/Object/ELF.h
Modified: llvm/trunk/include/llvm/Object/ELF.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Object/ELF.h?rev=212397&r1=212396&r2=212397&view=diff
==============================================================================
--- llvm/trunk/include/llvm/Object/ELF.h (original)
+++ llvm/trunk/include/llvm/Object/ELF.h Sun Jul 6 05:32:55 2014
@@ -42,9 +42,8 @@ StringRef getELFRelocationTypeName(uint3
inline std::pair<unsigned char, unsigned char>
getElfArchType(StringRef Object) {
if (Object.size() < ELF::EI_NIDENT)
- return std::make_pair((uint8_t)ELF::ELFCLASSNONE,(uint8_t)ELF::ELFDATANONE);
- return std::make_pair((uint8_t)Object.begin()[ELF::EI_CLASS],
- (uint8_t)Object.begin()[ELF::EI_DATA]);
+ return std::make_pair(ELF::ELFCLASSNONE, ELF::ELFDATANONE);
+ return std::make_pair(Object[ELF::EI_CLASS], Object[ELF::EI_DATA]);
}
template <class ELFT>
@@ -233,7 +232,7 @@ private:
StringRef Buf;
const uint8_t *base() const {
- return reinterpret_cast<const uint8_t *>(Buf.begin());
+ return reinterpret_cast<const uint8_t *>(Buf.data());
}
const Elf_Ehdr *Header;
More information about the llvm-commits
mailing list