[PATCH] LTO: rename the various makeLTOModule overloads

Peter Collingbourne peter at pcc.me.uk
Thu Jul 3 16:36:38 PDT 2014


On Thu, Jul 03, 2014 at 10:19:54AM -0400, Rafael EspĂ­ndola wrote:
> And rename the last standing makeLTOModule :-)

Hmm, since that one is private (and since my other patch changes its signature
such that it would probably need to be renamed again if I rename it now)
I think it's probably fine to leave it. We can always rename it after this
patch series, I guess.

> On 3 July 2014 10:17, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:
> > Actually, please also delete the name in the comments since they are
> > now out of sync:
> >
> >  /// makeLTOModule - Create an LTOModule. N.B. These methods take ownership of
> >  /// the buffer.
> > LTOModule *LTOModule::createFromFile

Done.

Thanks,
-- 
Peter



More information about the llvm-commits mailing list