[PATCH, PING] Fix common-code ppcf128 component access on little-endian
Ulrich Weigand
Ulrich.Weigand at de.ibm.com
Thu Jul 3 08:16:00 PDT 2014
Hal Finkel <hfinkel at anl.gov> wrote on 03.07.2014 06:03:57:
> > Here's an updated version of the patch that uses a helper routine
> > hasBigEndianPartOrdering. It also adds tests to cover the other
> > changes.
> >
> > In doing so I noticed that I missed a case in ExpandRes_BITCAST,
> > and once I added that, it turns out that the original change to
> > getCopyToParts is not necessary. (This is because that function
> > first uses a BITCAST to convert to an integer type, and then
> > operates on the integer type. The endian swap for ppc_fp128
> > takes place during the BITCAST already; no further swap is
> > required.)
> >
> > Does this look OK?
>
> Much better, thanks! LGTM.
>
> (Alp, thanks for the suggestion, the logic is indeed much clearer this
way).
Committed as revision 212274.
Thanks again,
Ulrich
More information about the llvm-commits
mailing list