[PATCH] [mach-o] wire up a dylib's install-name in more places
Nick Kledzik
kledzik at apple.com
Wed Jul 2 13:17:03 PDT 2014
On Jul 2, 2014, at 12:31 AM, Tim Northover <t.p.northover at gmail.com> wrote:
> Hi Nick,
>
>> The dylib-install-names.yaml file has four different RUN: groups/tests.
>>
>> The second one can be pulled out into its own file which has a MH_OBJECT
>> and a MH_DYLIB yaml doc linked together. Then you don’t need the Inputs/
>
> I don't think that would test the same thing. It would test the YAML
> -> NormalizedFile path instead of Binary -> NormalizedFile.
That is ok. We have (C++) unit tests to test Binary -> NormalizedFile. If there
is any issues there, those tests should catch it (and enhanced if they don’t
current test something there).
So, we should trust Binary -> NormalizedFile and therefore be able to
write test cases for everything else using YAML -> NormalizedFile.
-Nick
More information about the llvm-commits
mailing list