[llvm] r212062 - Speculatively fix some code handling Power64 MachO files

[Hal Finkel]

----- Original Message -----
> From: "Reid Kleckner" <rnk at google.com>
> To: "Hal Finkel" <hfinkel at anl.gov>, "Aaron Ballman" <aaron at aaronballman.com>
> Cc: "Reid Kleckner" <reid at kleckner.net>, "llvm-commits" <llvm-commits at cs.uiuc.edu>
> Sent: Monday, June 30, 2014 3:56:55 PM
> Subject: Re: [llvm] r212062 - Speculatively fix some code handling Power64 MachO files
> 
> 
> 
> 
> On Mon, Jun 30, 2014 at 1:30 PM, Hal Finkel < hfinkel at anl.gov >
> wrote:
> 
> 
> 
> ----- Original Message -----
> > From: "Reid Kleckner" < reid at kleckner.net >
> > To: llvm-commits at cs.uiuc.edu
> > Sent: Monday, June 30, 2014 3:12:59 PM
> > Subject: [llvm] r212062 - Speculatively fix some code handling
> > Power64 MachO files
> > 
> > Author: rnk
> > Date: Mon Jun 30 15:12:59 2014
> > New Revision: 212062
> > 
> > URL: http://llvm.org/viewvc/llvm-project?rev=212062&view=rev
> > Log:
> > Speculatively fix some code handling Power64 MachO files
> > 
> > MSVC was warning on a switch containing only default labels. In
> > this
> > instance, it looks like it uncovered a real bug. :)
> 
> Interesting. Can you file a PR against Clang for missing this
> warning?
> 
> 
> 
> There's an old one:
> http://llvm.org/bugs/show_bug.cgi?id=4546
> 
> 
> 
> Aaron sent a patch from this some time ago, but we didn't take it
> because we didn't think it'd be very high value.

Interesting. Well, now you have your example bug it catches! :-)

 -Hal

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory