[llvm] r212062 - Speculatively fix some code handling Power64 MachO files

[Hal Finkel]

----- Original Message -----
> From: "Reid Kleckner" <reid at kleckner.net>
> To: llvm-commits at cs.uiuc.edu
> Sent: Monday, June 30, 2014 3:12:59 PM
> Subject: [llvm] r212062 - Speculatively fix some code handling Power64 MachO	files
> 
> Author: rnk
> Date: Mon Jun 30 15:12:59 2014
> New Revision: 212062
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=212062&view=rev
> Log:
> Speculatively fix some code handling Power64 MachO files
> 
> MSVC was warning on a switch containing only default labels.  In this
> instance, it looks like it uncovered a real bug.  :)

Interesting. Can you file a PR against Clang for missing this warning?

Thanks again,
Hal

> 
> Modified:
>     llvm/trunk/lib/Object/MachOObjectFile.cpp
> 
> Modified: llvm/trunk/lib/Object/MachOObjectFile.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Object/MachOObjectFile.cpp?rev=212062&r1=212061&r2=212062&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Object/MachOObjectFile.cpp (original)
> +++ llvm/trunk/lib/Object/MachOObjectFile.cpp Mon Jun 30 15:12:59
> 2014
> @@ -1565,9 +1565,9 @@ Triple MachOObjectFile::getArch(uint32_t
>        return Triple();
>      }
>    case MachO::CPU_TYPE_POWERPC64:
> +    switch (CPUSubType & ~MachO::CPU_SUBTYPE_MASK) {
>      case MachO::CPU_SUBTYPE_POWERPC_ALL:
>        return Triple("ppc64-apple-darwin");
> -    switch (CPUSubType & ~MachO::CPU_SUBTYPE_MASK) {
>      default:
>        return Triple();
>      }
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory