[PATCH] [compiler-rt] Remove -fomit-frame-pointer from sanitizers CFLAGS

[Alexey Samsonov]

On Mon, Jun 30, 2014 at 6:23 AM, Alexander Potapenko <glider at google.com>
wrote:

> +kcc, samsonov
>
> Kostya, WDYT?
> I think adding -fno-omit-frame-pointers for asan_interceptors.cc is
> pretty cheap and we can just do that to fix the issues with
> interceptors.
>

I'm fine with it - looks like some interceptors can call back into the user
code, and we want to unwind the
stack correctly in this case. But I'd prefer being conservative and build
only a subset of files with -fno-omit-frame-pointer.


> But does -fomit-frame-pointers save us much provided that ASan
> binaries spend little time in the runtime library? (This may be
> different for TSan and MSan, however)
>
> On Fri, Jun 27, 2014 at 9:43 PM, Kuba Břečka <kuba.brecka at gmail.com>
> wrote:
> >> Will it help if we build the interceptors (and only them) without
> >> frame pointers? This sounds like the right thing to do.
> >
> > Yes, this will solve the issues I'm having.
> >
> > I'm trying to think of other use cases where missing frame pointer would
> > cause problems. How about profiling/sampling tools that take stack
> > snapshots?
> >
> > Kuba
> >
>
>
>
> --
> Alexander Potapenko
> Software Engineer
> Google Moscow
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



-- 
Alexey Samsonov
vonosmas at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140630/e8010d9a/attachment.html>