[PATCH] s/errc::not_supported/errc::function_not_supported/ in Support/Unix/Path.inc

Luqman Aden me+llvm at luqman.ca
Sun Jun 29 21:58:30 PDT 2014


Updated FileSystem.h.


On Sun, Jun 29, 2014 at 8:55 PM, Alp Toker <alp at nuanti.com> wrote:

> LGTM.
>
> And let's update the other mention of the old constant name in
> include/llvm/Support/FileSystem.h while we're at it.
>
>
>
> On 30/06/2014 06:44, Luqman Aden wrote:
>
>> I was building on Android and since it doesn't have futimes and futimens
>> it was hitting the else case which tries to use a variant that's not in the
>> errc enum. A simple enough change and I can build for Android again.
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>
> --
> http://www.nuanti.com
> the browser experts
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140629/9df75df7/attachment.html>
-------------- next part --------------
Index: include/llvm/Support/FileSystem.h
===================================================================
--- include/llvm/Support/FileSystem.h	(revision 212013)
+++ include/llvm/Support/FileSystem.h	(working copy)
@@ -510,8 +510,8 @@
 /// @brief Set the file modification and access time.
 ///
 /// @returns errc::success if the file times were successfully set, otherwise a
-///          platform specific error_code or errc::not_supported on platforms
-///          where the functionality isn't available.
+///          platform specific error_code or errc::function_not_supported on
+///          platforms where the functionality isn't available.
 std::error_code setLastModificationAndAccessTime(int FD, TimeValue Time);
 
 /// @brief Is status available?
Index: lib/Support/Unix/Path.inc
===================================================================
--- lib/Support/Unix/Path.inc	(revision 212013)
+++ lib/Support/Unix/Path.inc	(working copy)
@@ -468,7 +468,7 @@
   return std::error_code();
 #else
 #warning Missing futimes() and futimens()
-  return make_error_code(errc::not_supported);
+  return make_error_code(errc::function_not_supported);
 #endif
 }
 


More information about the llvm-commits mailing list