[llvm] r211950 - Adding some trailing whitespace after a comment previously ending with \ to ensure that it isn't lexed as a multiline comment. This silences some -Wcomment warnings.

Aaron Ballman aaron at aaronballman.com
Fri Jun 27 12:59:25 PDT 2014


On Fri, Jun 27, 2014 at 3:54 PM, David Blaikie <dblaikie at gmail.com> wrote:
> On Fri, Jun 27, 2014 at 12:05 PM, Aaron Ballman <aaron at aaronballman.com> wrote:
>> Author: aaronballman
>> Date: Fri Jun 27 14:05:17 2014
>> New Revision: 211950
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=211950&view=rev
>> Log:
>> Adding some trailing whitespace after a comment previously ending with \ to ensure that it isn't lexed as a multiline comment. This silences some -Wcomment warnings.
>
> I believe clang's -Wcomment is smart enough not to warn here. Should
> we just disable GCC's?

I think that makes more sense. I just saw that even with this change,
the warnings are still triggered. I am going to back this change out
since it turned out to not be helpful.

~Aaron



More information about the llvm-commits mailing list