[Polly] Allow multiple reductions in one statement

[Johannes Doerfert]

Hey,

I didn’t commit it yet because I changed a lot of comments and a little bit of code.
Is this OK with you?

Best regards,
  Johannes

--

Johannes Doerfert
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation


-----Original Message-----
From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Johannes Doerfert
Sent: Thursday, June 26, 2014 11:23 PM
To: Tobias Grosser
Cc: llvm-commits at cs.uiuc.edu; 'Sebastian Pop'; 'zino'
Subject: Re: [Polly] Allow multiple reductions in one statement

I will add/update the comments and commit message tomorrow. Then I'll commit it afterwards.

Thanks for the comments!

On 06/27, Tobias Grosser wrote:
> On 27/06/2014 02:10, Johannes Doerfert wrote:
> >I changed the first loop nest to perform the task in linear time; the 
> >second is still as it was.
> >I used the summary in the last mail as git commit message (thus I 
> >have the comment in there).
> >Should I also add it to the code?
> >
> >Is it ok (modulo adding the comment in the code also)?
> 
> Here some more comments:
> 
> - First of all, the commit message is now outdated. You don't iterate 
> over all pairs anymore, no
> 
> - Comments in the source code:
> 
>   - collectCandiateReductionLoads has little comments. The
>     use of Candidates is not commented and it is not clear why more than
>     one candidate could be pushed (I understand this, but it may not be
>     clear to the reader)
> 
>   - You explain that you check for non-overlapping accesses, but it is
>     not clear why this is needed and why this is sufficient.
> 
> Otherwise, LGTM.
> 
> Tobias
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

--

Johannes Doerfert

Employee of Qualcomm Innovation Center, Inc.

Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Allow-multiple-reductions-per-statement_v3.patch
Type: application/octet-stream
Size: 58551 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140627/c25fb841/attachment.obj>