[PATCH] Removed pattern checks in instruction simplify/ combine which are now handled in SimplifyUsingDistributiveLaws()

Dinesh Dwivedi dinesh.d at samsung.com
Thu Jun 26 02:05:28 PDT 2014


Thanks :)

================
Comment at: test/Transforms/InstCombine/distribute.ll:36
@@ +35,3 @@
+define i32 @factorize4(i32 %x, i32 %y) {
+; CHECK-LABEL: @factorize4(
+  %sh = shl i32 %y, 1
----------------
Jingyue Wu wrote:
> Could you add a comment that translates the IR into math expressions? Just as what you did for factorize1|2|3. It would be much easier to follow. Thanks! 
updated.

================
Comment at: test/Transforms/InstCombine/distribute.ll:48
@@ +47,3 @@
+; CHECK-LABEL: @factorize5(
+  %sh = mul i32 %y, 2
+  %ml = mul i32 %sh, %x
----------------
Jingyue Wu wrote:
> ditto
updated.

http://reviews.llvm.org/D4253






More information about the llvm-commits mailing list