[llvm] r211668 - Fix another asserting method in the null streamer.

[Philip Reames]

On 06/25/2014 11:00 AM, Rafael Espíndola wrote:
> On 25 June 2014 13:32, Philip Reames <listmail at philipreames.com> wrote:
>> Rafael,
>>
>> Could this be addressed by overriding this method on the null streamer
>> class?  Removing the check in the generic base class seems excessive.
> Why? We wouldn't want it to assert on the RecordStreamer for example.
This comes down to a question of what the best default is for the base 
class.  If you're implementing a new derived class, is calling this 
function without overriding it a source of error?  If so, the check is 
worth keeping.  Otherwise, it isn't.  I don't know the semantics of the 
MC hierarchy enough to address this.

I brought the issue up since I saw three changes in a row (two from you, 
one from Nakamura) which seem to solve similar problems with different 
solutions.  That raised a question in my mind, so I asked.

Philip