[llvm] r211730 - [FastISel][X86] Only fold the cmp into the select when both instructions are in the same basic block.

Eric Christopher echristo at gmail.com
Wed Jun 25 13:58:05 PDT 2014


I agree with that, I meant refactoring out the duplicated code.
On Jun 25, 2014 1:57 PM, "Juergen Ributzka" <juergen at apple.com> wrote:

> The comments are in three separate functions, so I rather keep it verbose
> in case someone wonders why this limitation is in place.
>
> On Jun 25, 2014, at 1:49 PM, Eric Christopher <echristo at gmail.com> wrote:
>
> Lot of cutting and pasting here. Any chance of a refactor?
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140625/68c674c4/attachment.html>


More information about the llvm-commits mailing list