[PATCH] cmake: NDEBUG needlessly defined in non-Release builds

[Alp Toker]

On 25/06/2014 20:11, Reid Kleckner wrote:
> Sure, I can review this.

How about posting this patch to the public reviews list?

I'm working on the LLVM_ENABLE_ASSERTIONS / NDEBUG cleanups for 3.5 and 
this reply was the first I saw of the patch submission.

Using an email client will ensure the right people see and review the patch.

Alp.

> LLVM_ENABLE_ASSERTIONS is supposed to directly control NDEBUG, and Release/Debug is supposed to control optimizations and debug info.  Therefore IMO this is correct as written.
>
> I imagine it is confusing to users to have to explicitly flip LLVM_ENABLE_ASSERTIONS=ON in a debug build.  I don't think adding tristate logic to detect when the user does a debug build without setting LLVM_ENABLE_ASSERTIONS is worth it, though.
>
> Does that seem reasonable?
>
> I don't know why the VS and XCode logic exists, that seems annoyingly inconsistent.
>
> http://reviews.llvm.org/D4257
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-- 
http://www.nuanti.com
the browser experts