[Patch][LNT] fix python error in compile.py when runN failed
Steven Wu
stevenwu at apple.com
Tue Jun 24 09:34:57 PDT 2014
Sorry I forgot to attach the patch in the previous email. Now attached.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: runN_failed.patch
Type: application/octet-stream
Size: 1025 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140624/c377a73d/attachment.obj>
-------------- next part --------------
> On Jun 23, 2014, at 6:06 PM, Steven Wu <stevenwu at apple.com> wrote:
>
> LNT currently throws python errors when runN failed in compile.py. It throws error messages about it cannot parse stdout, stderr is not empty and runN does not return 0.
> Ideally, the check after runN should performed in the opposite order. stdout shouldn’t be parsed if runN does not return 0. Since it is expected that runN can fail during the test, g_log.error should be used to print the error instead of throw python error messages.
>
> Please commit for me after review.
More information about the llvm-commits
mailing list