mips64: Use __clear_cache builtin instead of cacheflush

Daniel Sanders Daniel.Sanders at imgtec.com
Mon Jun 23 04:00:14 PDT 2014


LGTM. I was on the fence about the "Use compiler's builtin" comment but I ended up deciding that it's not obvious that __clear_cache is a builtin (because it lacks the usual __builtin_ prefix).

I know you don't have commit access so I'll commit it for you once I've tested it on a MIPS host.

By the way, patches should be made from the root of the project so that they have the full path in them.

Thanks.

From: Duane Sand
Sent: 20 June 2014 23:56
To: llvm-commits at cs.uiuc.edu
Cc: Daniel Sanders
Subject: RE: mips64: Use __clear_cache builtin instead of cacheflush

Patch attached as a .txt file
________________________________
From: Duane Sand
Sent: Friday, June 20, 2014 2:50 PM
To: llvm-commits at cs.uiuc.edu
Cc: Daniel Sanders
Subject: mips64: Use __clear_cache builtin instead of cacheflush
mips64 Android bionic has dropped the mips32-specific cacheflush() routine.
Use the compiler's __clear_cache builtin on mips and mips64, as already done for arm and aarch64.
Delete dead code for calling Android's mutated-arg version of mips32 cacheflush().

See https://android-review.googlesource.com/#/c/96717 for previous discussion of this at aosp.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140623/9a2b79f3/attachment.html>


More information about the llvm-commits mailing list