[PATCH] Add new debug kind LocTrackingOnly.

[Diego Novillo]

On Fri, Jun 20, 2014 at 4:17 PM, David Blaikie <dblaikie at gmail.com> wrote:

> As to the other comments about whether to add a value to the enum or use a
> flag in createCompileUnit - for now I think I'm going to err on the side of
> preferring a flag in createCompileUnit.
>

Sure. I'll restore the original behaviour then.


> The Clang-side support for this should obviously look a fair bit like GMLT
> (indeed if you put the enum value for this mode before GMLT, it should get
> most/all the right behavior by default (though you might have to fix up
> some comparisons for == GMLT to <= GMLT)). At some point we can probably
> simplify this even further so all the scopes are just simple line/file info
> without having to create any compile units, functions, lexical scopes, etc.
>

Right. At the moment, the Clang-side support for this looks exactly like
-gmlt. I've not needed to change anything since the code that checks for
equality to DebugLineTablesOnly does not really affect loc tracking. I
figured we can tweak those later (though I'll gladly change them to <=,
it's only two spots that need fixing).


> Comment at: test/Transforms/LoopVectorize/X86/vectorization-remarks.ll:9
> @@ +8,3 @@
> +; DEBUG-OUTPUT-NOT: .loc
> +; DEBUG-OUTPUT-NOT: {{.*}}.debug_info{{.*}}
> +
> ----------------
> You don't need the {{.*}} on either side here, FileCheck looks for subline
> matches by default (which is why the .loc as you've written it is correct).
>

Done.


Thanks. Diego.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140620/273abf3b/attachment.html>