[PATCH] Deprecate and remove OwningPtr

[Alp Toker]

On 19/06/2014 10:04, Aaron Ballman wrote:
> On Thu, Jun 19, 2014 at 3:03 AM, Chandler Carruth <chandlerc at google.com> wrote:
>> On Thu, Jun 19, 2014 at 7:53 AM, Craig Topper <craig.topper at gmail.com>
>> wrote:
>>> On Wed, Jun 18, 2014 at 11:33 PM, Aaron Ballman <aaron at aaronballman.com>
>>> wrote:
>>>> On Thu, Jun 19, 2014 at 1:30 AM, Alp Toker <alp at nuanti.com> wrote:
>>>>> The attached patch slaps some deprecation attributes on the OwningPtr
>>>>> classes and removes associated unit tests.
>>>>>
>>>>> I'll follow up and remove the OwningPtr.h header completely a couple of
>>>>> days
>>>>> after to provide a last-chance grace period.
>>>> "A couple of days" is not exactly a grace period, especially given how
>>>> many folks are at the standards meetings currently. Was this grace
>>>> period discussed at some point?
>>>
>>> I believe most in tree uses of OwningPtr were removed in March or April.
>>> The last in tree usage was removed by me on May 21. Hopefully by now anyone
>>> even sort of watching the list would know that OwningPtr's days were
>>> numbered.
>>
>> I think we've given plenty of grace period. Just remove it, no need to jump
>> through deprecation hoops.
> Fair enough. I was mostly concerned about out-of-tree branches
> tracking against ToT (since this is in ADT). I'm definitely not
> opposed to removing OwningPtr. ;-)

Removed in r211259!

Alp.

>
> ~Aaron
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-- 
http://www.nuanti.com
the browser experts