[llvm] r211225 - Use LL suffix for literal that should be 64-bits.

Duncan P. N. Exon Smith dexonsmith at apple.com
Wed Jun 18 15:10:56 PDT 2014


> On 2014 Jun 18, at 14:40, Matt Arsenault <Matthew.Arsenault at amd.com> wrote:
> 
> Author: arsenm
> Date: Wed Jun 18 16:40:43 2014
> New Revision: 211225
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=211225&view=rev
> Log:
> Use LL suffix for literal that should be 64-bits.
> 
> This hopefully fixes Windows
> 
> Modified:
>    llvm/trunk/lib/Target/R600/AMDGPUISelLowering.cpp
> 
> Modified: llvm/trunk/lib/Target/R600/AMDGPUISelLowering.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/R600/AMDGPUISelLowering.cpp?rev=211225&r1=211224&r2=211225&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Target/R600/AMDGPUISelLowering.cpp (original)
> +++ llvm/trunk/lib/Target/R600/AMDGPUISelLowering.cpp Wed Jun 18 16:40:43 2014
> @@ -1640,7 +1640,7 @@ SDValue AMDGPUTargetLowering::LowerFTRUN
>   SignBit64 = DAG.getNode(ISD::BITCAST, SL, MVT::i64, SignBit64);
> 
>   SDValue BcInt = DAG.getNode(ISD::BITCAST, SL, MVT::i64, Src);
> -  const SDValue FractMask = DAG.getConstant((1L << FractBits) - 1, MVT::i64);
> +  const SDValue FractMask = DAG.getConstant((1LL << FractBits) - 1, MVT::i64);

`UINT64_C(1)` (or `INT64_C(1)`) might be better here.

> 
>   SDValue Shr = DAG.getNode(ISD::SRA, SL, MVT::i64, FractMask, Exp);
>   SDValue Not = DAG.getNOT(SL, Shr, MVT::i64);
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list