[PATCH] [asm-instrumentation] Removed assembly helpers for asan.
Evgeniy Stepanov
eugenis at google.com
Wed Jun 18 06:01:07 PDT 2014
LGTM, great.
================
Comment at: lib/asan/tests/asan_asm_test.cc:200
@@ +199,3 @@
+#if defined(__i386__)
+ TestAsmWrite<U8>("WRITE of size 4");
+#else
----------------
Perhaps it's better to just skip the U8 test on x86_32 - it's not really a 64-bit store, and it duplicates the U4 test.
http://reviews.llvm.org/D4193
More information about the llvm-commits
mailing list