[PATCH] [ValueTracking] Extend range metadata to call/invoke
hfinkel at anl.gov
hfinkel at anl.gov
Wed Jun 18 01:02:59 PDT 2014
LGTM, thanks!
================
Comment at: lib/Analysis/ValueTracking.cpp:201
@@ -201,1 +200,3 @@
+ ConstantInt *Lower = cast<ConstantInt>(Ranges.getOperand(2 * i + 0));
+ ConstantInt *Upper = cast<ConstantInt>(Ranges.getOperand(2 * i + 1));
ConstantRange Range(Lower->getValue(), Upper->getValue());
----------------
I don't like the extra spaces here around the * operator.
================
Comment at: lib/Analysis/ValueTracking.cpp:740
@@ -736,1 +739,3 @@
+ computeKnownBitsFromRangeMetadata(*MD, KnownZero);
+ }
if (IntrinsicInst *II = dyn_cast<IntrinsicInst>(I)) {
----------------
We don't need {} around a single-statement if body.
http://reviews.llvm.org/D4187
More information about the llvm-commits
mailing list