[llvm] r211103 - Fixed jump threading going to infinite loop.

Dinesh Dwivedi dinesh.d at samsung.com
Tue Jun 17 23:23:47 PDT 2014


Sorry, committed this patch too soon. How about changing comment as follows.

  // Remove unreachable blocks from function as they may result in infinite loop
  // We do threading if we found something profitable. But there may be two or
  // more conflicting cases where both are profitable and one results in undoing
  // other. This issue will not come for reachable blocks as we don't jump
  // thread back edges. Unreachable blocks having cycle with no back edge may
  // result in infinite loop.
  removeUnreachableBlocks(F);

Regards
Dinesh Dwivedi

------- Original Message -------
Sender : Rafael EspĂ­ndola<rafael.espindola at gmail.com> 
Date   : Jun 17, 2014 20:34 (GMT+05:30)
Title  : Re: [llvm] r211103 - Fixed jump threading going to infinite loop.

> +  // Remove unreachable blocks from function as they may result in infinite loop.
> +  removeUnreachableBlocks(F);
> +

I would be nice to say how :-)

Cheers,
Rafael




More information about the llvm-commits mailing list