[LNT] Parse --version correctly from CMake builds

Chris Matthews chris.matthews at apple.com
Tue Jun 17 11:43:51 PDT 2014


I do think this needs to be fixed in the build system, LNT is not the only consumer of version information.   It would also be good for LNT to support older cmake builds, so lets add this patch as well.

Patch LGTM.

> On Jun 17, 2014, at 10:37 AM, David Blaikie <dblaikie at gmail.com> wrote:
> 
> Worth fixing the cmake build instead? Having branch/revision number in
> there is rather nice to have.
> 
> (but yeah, if this is the substantially easier fix, I can't complain
> about it making broken things not so broken)
> 
> On Tue, Jun 17, 2014 at 5:21 AM, James Molloy <james.molloy at arm.com> wrote:
>> Hi Yi, Chris,
>> 
>> 
>> 
>> LNT currently fails to parse clang’s –version string correctly for CMake
>> builds. CMake builds do not emit the branch name, they only emit the
>> revision. Currently LNT thinks the revision number is the branch name, which
>> also means it fails to infer the run_order correctly for submission.
>> 
>> 
>> 
>> The attached simple patch fixes this.
>> 
>> 
>> 
>> OK to commit?
>> 
>> 
>> 
>> Cheers,
>> 
>> 
>> 
>> James
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140617/f9fbfd91/attachment.html>


More information about the llvm-commits mailing list