[PATCH] Alternative way of representing comdats

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Tue Jun 17 08:09:53 PDT 2014


Hi nicholas, rnk, majnemer,

This is a variation on http://reviews.llvm.org/D4094

I think it is at feature parity. In particular, lib/Linker has not been updated and passes have not been audited to not modify the set of symbols in a comdat.

What it does is change the representation to not be a Value. It is intended as a way of making a discussion about these treadeoffs more concrete.

http://reviews.llvm.org/D4178

Files:
  docs/LangRef.rst
  include/llvm-c/Core.h
  include/llvm/Bitcode/LLVMBitCodes.h
  include/llvm/IR/Comdat.h
  include/llvm/IR/GlobalObject.h
  include/llvm/IR/GlobalValue.h
  include/llvm/IR/Module.h
  lib/AsmParser/LLLexer.cpp
  lib/AsmParser/LLLexer.h
  lib/AsmParser/LLParser.cpp
  lib/AsmParser/LLParser.h
  lib/AsmParser/LLToken.h
  lib/Bitcode/Reader/BitcodeReader.cpp
  lib/Bitcode/Reader/BitcodeReader.h
  lib/Bitcode/Writer/BitcodeWriter.cpp
  lib/Bitcode/Writer/ValueEnumerator.cpp
  lib/Bitcode/Writer/ValueEnumerator.h
  lib/CodeGen/TargetLoweringObjectFileImpl.cpp
  lib/IR/AsmWriter.cpp
  lib/IR/AsmWriter.h
  lib/IR/CMakeLists.txt
  lib/IR/Comdat.cpp
  lib/IR/Globals.cpp
  lib/IR/Module.cpp
  test/Feature/comdat.ll
  test/Instrumentation/AddressSanitizer/do-not-instrument-llvm-metadata.ll
  test/MC/COFF/comdat.ll
  test/MC/ELF/comdat.ll
  test/MC/MachO/comdat.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D4178.10503.patch
Type: text/x-patch
Size: 50918 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140617/a8e362c0/attachment.bin>


More information about the llvm-commits mailing list