[PATCH] [AArch64] Fix a pattern match failure caused by creating improper CONCAT_VECTOR.

Tim Northover t.p.northover at gmail.com
Tue Jun 17 01:58:02 PDT 2014


Hi Kevin,

On 17 June 2014 09:33, Kevin Qin <kevinqindev at gmail.com> wrote:
> After your modification, codes become cleaner and should execute faster. Thanks for this refactoring! I've tried more tests on this
patch, showing no regression. As I have no suggestions on code changes
any more, can I commit your version directly?

I think it'd be good to at least add a comment to the new block
explaining what it's doing (I'm happy to leave that up to you if you
want). But other than that I've looked it over again and am reasonably
happy.

Cheers.

Tim.



More information about the llvm-commits mailing list