[Mesa-dev] [PATCH 1/2] R600/SI: add Gather4 intrinsics (v2)

Marek Olšák maraeo at gmail.com
Mon Jun 16 18:51:12 PDT 2014


Is there any specific reason for using SDNodes for everything?

Using intrinsics directly in patterns seems to result in a smaller
amount of code, which is always good.

Marek

On Mon, Jun 16, 2014 at 8:12 PM, Matt Arsenault
<Matthew.Arsenault at amd.com> wrote:
> On 06/16/2014 08:45 AM, Tom Stellard wrote:
>>
>> You don't need to add new SDNodes for all these instructions, you can just
>> use
>> the intrinsic directly in the pattern.
>>
>> The only reason to add SDNodes, is if there are optimizations / special
>> lowering
>> we can do for these instructions.
>
> I kind of like having everything consistently use an SDNode



More information about the llvm-commits mailing list