[PATCH] [Jump-Threading] Fixed jump threading hang issues (PR15386, PR15851)
Rafael Ávila de Espíndola
rafael.espindola at gmail.com
Mon Jun 16 13:10:23 PDT 2014
LGTM with two nits.
================
Comment at: lib/Transforms/Scalar/JumpThreading.cpp:161
@@ -160,1 +160,3 @@
+ removeUnreachableBlocks(F);
+
----------------
Please include a comment saying why this is not just an optimization.
================
Comment at: test/Transforms/JumpThreading/pr15851_hang.ll:1
@@ +1,2 @@
+; RUN: timeout 10s opt -S -jump-threading < %s | FileCheck %s
+
----------------
I don't think timeout is portable. Just run opt directly.
http://reviews.llvm.org/D3991
More information about the llvm-commits
mailing list