[PATCH] Fix illegal relocations in X86FastISel

Eric Christopher echristo at gmail.com
Mon Jun 16 10:54:08 PDT 2014


As a note it looks like Louis ended up thinking this was a +r for it
and committed it. I've started a review thread there.

-eric

On Sun, Jun 15, 2014 at 11:52 PM, Kostya Serebryany <kcc at google.com> wrote:
> +samsonov (for test/DebugInfo/X86/debug-loc-asan.ll)
>
>
> On Sat, Jun 14, 2014 at 1:42 AM, Louis Gerbarg <lgg at apple.com> wrote:
>>
>> It turns out we have been generating illegal relocations in X86FastISel
>> when compiling static 64 bit code for years. In many cases the illegal code
>> actually worked because of how the binaries were laid out, but it could also
>> fail or generate bad code.
>>
>> As it turns out this mis-generated code also happens to be occur in the
>> test case test/DebugInfo/X86/debug-loc-asan.ll, so the fix breaks that. I
>> have included fixes for that test case as well, but someone should look it
>> over as I am not familiar with the asan annotations.
>>
>> Louis
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



More information about the llvm-commits mailing list