[llvm] r210782 - This removes TODO added in http://reviews.llvm.org/D3658

Dinesh Dwivedi dinesh.d at samsung.com
Mon Jun 16 01:00:42 PDT 2014


Hi Tobias,

Sorry. Title of the commit was supposed to be 'Added transform for ABS(NABS(X)) and NABS(ABS(X))'
But I missed this while writing commit message. I agree and will mention revision while mentioning previous
commits in future commits.

Regards
Dinesh Dwivedi

------- Original Message -------
Sender : Tobias Grosser<tobias at grosser.es> 
Date   : Jun 13, 2014 12:46 (GMT+05:30)
Title  : Re: [llvm] r210782 - This removes TODO added in
 http://reviews.llvm.org/D3658

On 12/06/2014 16:06, Dinesh Dwivedi wrote:
> Author: dinesh
> Date: Thu Jun 12 09:06:00 2014
> New Revision: 210782
>
> URL: http://llvm.org/viewvc/llvm-project?rev=210782&view=rev
> Log:
> This removes TODO added in http://reviews.llvm.org/D3658

Any reason you don't reference the commit id directly? That
seems what most people do in general. I personally would prefer it
as I don't need an internet connection to look up the relevant commit.

Tobias




More information about the llvm-commits mailing list