[llvm] r210920 - Finishing touch for the std::error_code transition.

[Jeffrey Yasskin]

On Fri, Jun 13, 2014 at 7:45 PM, Chandler Carruth <chandlerc at google.com> wrote:
>
> On Fri, Jun 13, 2014 at 6:42 PM, Hal Finkel <hfinkel at anl.gov> wrote:
>>
>> > +// * std::errc is a namespace in some implementations. That meas

I'm not sure exactly what Rafael means here, but it sounds like those
implementations don't match the standard. [syserr] requires std::errc
to be an enum class, not a namespace.

>> > that ADL
>> > +//   doesn't work and it is sometimes necessary to write
>> > std::make_error_code
>> > +//   or in templates:
>> > +//   using std::make_error_code;
>> > +//   make_error_code(...);
>> > +//
>> > +//   with this enum it is safe to always just use make_error_code.
>>
>> Should we file a defect report?
>
>
> Marshall or Jeffrey would know better.

Defect reports about ADL working badly are either a lost cause, or a
commitment to a huge amount of work.