[llvm] r210641 - Create macro INITIALIZE_TM_PASS.

[Eric Christopher]

On Fri, Jun 13, 2014 at 3:46 PM, Rafael Avila de Espindola
<rafael.espindola at gmail.com> wrote:
>
>
> Sent from my iPhone
>
>> On Jun 13, 2014, at 18:32, Eric Christopher <echristo at gmail.com> wrote:
>>
>>> On Fri, Jun 13, 2014 at 3:28 PM, Chandler Carruth <chandlerc at google.com> wrote:
>>>
>>> On Fri, Jun 13, 2014 at 11:02 PM, Rafael Avila de Espindola
>>> <rafael.espindola at gmail.com> wrote:
>>>>
>>>>> On Jun 13, 2014, at 17:26, Eric Christopher <echristo at gmail.com> wrote:
>>>>>
>>>>> Ack. This is a terrible idea. (As there's a thread on it)
>>>>>
>>>>> But I'm not sure what the current status is here, did this patch get
>>>>> reverted?
>>>>
>>>>
>>>> I don't think so. My understanding is that Jiangning Liu is working to
>>>> move the pass to lib/CodeGen. Would that make it ok for you or there are
>>>> other issues besides the layering problem?
>>>
>>>
>>> I'm not sure the nature of the problem Eric is hitting, but my problems are
>>> well addressed by the patch already mailed out on this thread. For me, that
>>> would be a step in the right directoin.
>>
>> Oh, I'm just going to have to rewrite it to avoid taking a TM, but
>> this isn't making it any worse afaict.
>>
>
> Because it is a module pass and you are changing each function to have a different one?
>

Trying to avoid passes using a TargetMachine. There's almost no cause
for it and using it to get to TLI is pretty bad even if nothing is
currently using that aspect of it.

-eric

>
>> -eric