[llvm] r210641 - Create macro INITIALIZE_TM_PASS.

[Eric Christopher]

On Wed, Jun 11, 2014 at 11:17 AM, Rafael Espíndola
<rafael.espindola at gmail.com> wrote:
> On 11 June 2014 14:00, Quentin Colombet <qcolombet at apple.com> wrote:
>> I think this needs more discussion.
>>
>> I have proposed something similar back in January and we agreed it was not a
>> good idea to expose such interface:
>> http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20140113/201619.html
>>
>> The bottom line is, this situation is supposed to be the exception and we do
>> not want to provide support for it. The rational is that using target
>> interface, you may violate the layer of LLVM, i.e., you may create a
>> libraries dependencies.
>
> Thanks for the pointer.
>
> If I understand it correctly, the objection is not so much to the
> macro, but to spreading the use of TM in IR passes.
>

The use of TM anywhere :)

> Andrew, given what GlobalMerge is doing, do you think it should be
> rewritten to use TTI?

Yes.

>
> The macro would still be used in AtomicExpandLoadLinkedPass and
> CodeGenPrepare. IMHO it actually makes it easier to spot the llvm
> passes that are using TM.
>

The macro is still pretty terrible as well, but could be done for now.
It'll have to go shortly though.

-eric